feat: 120 Hz default com_maxfps; easybuild -vulkan for Vulkan builds#11
Conversation
- Default com_maxfps 120 (was 125) for common 120 Hz displays; range 20-500 unchanged. - easybuild.sh: -vulkan/-vk sets FEATURE_RENDERER_VULKAN=1, passes to CMake, forces RENDERER_DYNAMIC on when needed for multi-backend builds. - README: Vulkan easybuild flag, draft RT PR pointer, high-refresh notes. Co-authored-by: Tim Fox <timfox@outlook.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25b57abb1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ "${RENDERER_DYNAMIC:-1}" -eq 0 ]; then | ||
| einfo "Re-enabling dynamic renderer build (required when building Vulkan + OpenGL)" | ||
| RENDERER_DYNAMIC=1 |
There was a problem hiding this comment.
This re-enable check only executes when -vulkan is parsed, so argument order changes behavior: running easybuild.sh ... -vulkan -nodynamic leaves RENDERER_DYNAMIC=0 while FEATURE_RENDERER1 (default) and FEATURE_RENDERER_VULKAN=1 are both enabled, which then triggers CMake's fatal guard (Only one renderer can be built at a time when building static libraries in cmake/ETLBuildRenderer.cmake). The script should enforce this constraint after all options are processed so -vulkan is safe regardless of flag order.
Useful? React with 👍 / 👎.
2 participants
Summary
com_maxfpsdefault 120 (was 125) so fresh installs align with common 120 Hz panels;Cvar_CheckRange20–500 unchanged. Users who want 125+ can still set the cvar.easybuild.sh:-vulkan/-vkenablesFEATURE_RENDERER_VULKAN, passes-DFEATURE_RENDERER_VULKANto CMake, and turnsRENDERER_DYNAMICback on when needed (CMake requires dynamic libs when multiple renderers are selected).r_swapIntervalvs frame cap.Full Vulkan implementation
Shipping a complete Vulkan path (feature parity with GL1, all maps/mods, validation-clean) is large ongoing work; this PR improves defaults and build ergonomics. Ray-tracing / RHI depth remains in draft PR #5 until reviewed and de-risked.
Testing
CI should exercise existing default renderer matrix; Vulkan is still off in CI unless we add a job later.